search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.49k stars 24.89k forks source link

fix/SearchStatesIt_failures #117618

Closed drempapis closed 2 days ago

drempapis commented 4 days ago

It seems that there is a race condition where this call does not pick up all three nodes that this assert is expecting.

To mitigate and test the issue, I added an "assertBusy" busy spin in the nodes lookup, waiting until all three nodes appear.

Solves #116617 and #116618

elasticsearchmachine commented 4 days ago

Hi @drempapis, I've created a changelog YAML for you.

elasticsearchmachine commented 3 days ago

Pinging @elastic/es-search-foundations (Team:Search Foundations)

drempapis commented 3 days ago

@javanna Is this approach enough to merge the muted tests for v9.0.0 and v8.18.0?

drempapis commented 2 days ago

In this pr #116577, the boolean bwc_tests_enabled in elasticsearch/build.gradle did not flip value before merging, provoking some compatibility failures, which the elastic search machine automatically reported. There is nothing to do here; just unmute the two tests.

elasticsearchmachine commented 2 days ago

Hi @drempapis, I've updated the changelog YAML for you.

elasticsearchmachine commented 2 days ago

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 117618

drempapis commented 2 days ago

We manually backported changes to v8.18.0 #117729