[8.x](backport #4142) Fix server.address field in HTTP logs - Githubissues

elastic / fleet-server

The Fleet server allows managing a fleet of Elastic Agents.

Other

11 stars 81 forks source link

[8.x](backport #4142) Fix server.address field in HTTP logs #4148

Open mergify[bot] opened 23 hours ago

mergify[bot] commented 23 hours ago

What is the problem this PR solves?

server.address is empty in HTTP request logs.

How does this PR solve the problem?

Populate server.address using the interface associated with http.LocalAddrContextKey.

How to test this PR locally

start a fleet-server and make an HTTP request.

Design Checklist

[x] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
[x] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
[x] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

[x] I have commented my code, particularly in hard-to-understand areas
~~I have made corresponding changes to the documentation~~
~~I have made corresponding change to the default configuration files~~
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added an entry in ./changelog/fragments using the changelog tool
This is an automatic backport of pull request #4142 done by Mergify.

elastic-sonarqube[bot] commented 22 hours ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube