elastic / hey-apm

Basic load generation for apm-server built on hey
Apache License 2.0
16 stars 16 forks source link

Ensure empty string values are handled correct in query. #133

Closed simitt closed 5 years ago

simitt commented 5 years ago

Running hey-apm -bench does not set a service name, leading to query for an empty value with a must match query on a text field. Ensure to specifically query for keyword in such cases.

fixes elastic/hey-apm#132

jalvz commented 5 years ago

would #132 be fixed by passing a non empty default value to https://github.com/elastic/hey-apm/blob/master/main.go#L24?

simitt commented 5 years ago

It would be fixed with that, but as soon as another empty string is added, the same issue comes up.