[uiActions] Allow brushing and filtering at the same time using combined context

[flash1293]

Right now it's either possible to emit an ui action for the VALUE_CLICK_TRIGGER or SELECT_RANGE_TRIGGER for chart interactions because our chart types allowed these two things.

However the elastic-charts heatmap allows selecting a rectangle of cells at the same time - if one of the axes is a histogram axis, this is basically a click and select range action at the same time:

This should show the filter selection modal with three lines:

• Apply gz
• Apply css
• Apply time range from x to y

I suggest extending the value click trigger for this to handle ranges as well:

Current state:

export interface ValueClickContext<T extends IEmbeddable = IEmbeddable> {
  embeddable?: T;
  data: {
    data: Array<{
      table: Pick<Datatable, 'rows' | 'columns'>;
      column: number;
      row: number;
      value: any;
    }>;
    timeFieldName?: string;
    negate?: boolean;
  };
}

Extension:

export interface ValueClickContext<T extends IEmbeddable = IEmbeddable> {
  embeddable?: T;
  data: {
    data: Array<{
      table: Pick<Datatable, 'rows' | 'columns'>;
      column: number;
      row: number;
      value: any;
    } | {
      table: Pick<Datatable, 'rows' | 'columns'>;
      column: number;
      range: number[];
    }>;
    timeFieldName?: string;
    negate?: boolean;
  };
}

This is basically pulling the range context data into the value click context.

What do you think @ppisljar ?

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[ppisljar]

would that mean we get rid of the range select action completely ? should we simplify the typing then and say that we always do range selection, but possibly startdate === enddate for the case of simple value click ?

[flash1293]

No strong opinion on how the API is going to look like

[ppisljar]

i would suggest something like this:

export interface ValueClickContext<T extends IEmbeddable = IEmbeddable> {
  embeddable?: T;
  data: {
    data: Array<{
      table: Pick<Datatable, 'rows' | 'columns'>;
      column: number;
      range: number[];
      value: any;
    }>;
    timeFieldName?: string;
    negate?: boolean;
  };
}

if range.from === range.to then its a simple click

• [ ] update the type of VALUE_CLICK_TRIGGER context
• [ ] update value_click action to work with the new type
• [ ] update all current usages of VALUE_CLICK_TRIGGER with correct context
• [ ] update all current usages of RANGE_SELECT_TRIGGER to rather use new VALUE_CLICK_TRIGGER
• [ ] remove RANGE_SELECT_TRIGGER and range select action

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[markov00]

This is now possible to implement in the tooltip actions, we can add a function that says filter both time and selected series.