elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.01k stars 8.25k forks source link

[Discover] Use custom field labels consistently in Discover #151510

Open davismcphee opened 1 year ago

davismcphee commented 1 year ago

While testing data view field editing, I noticed we don't use custom field labels consistently in Discover which can lead to confusion for users. I didn't track down everywhere where we fail to use custom field labels, so that work would need to be done as part of this issue, but I can provide a couple examples of what I mean to start.

When saving a data view field with a custom label, the save toast does not use the custom label:

custom_label_save

When toggling a column in the table from the expanded document view, the add/remove toast does not use the custom label:

custom_label_column

Ideally we would use custom field labels consistently across Discover to prevent confusion.

elasticmachine commented 1 year ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

osmanis commented 1 year ago

Same goes for the query bar:

Screen Shot 2023-03-03 at 12 46 31 AM