Open kpollich opened 1 year ago
Pinging @elastic/fleet (Team:Fleet)
@kpollich are we still doing this one for the MVP or are we only focusing on #155910?
@joshdover We'll only be doing "local" routing rules for the MVP in 8.10. So yes, the scope has been pared down to https://github.com/elastic/kibana/issues/155910 for MVP.
@juliaElastic Do we know how this should work with input-packages? Can we specify the input package dataset as target dataset for routing rules? Because the problem with input packages is that the dataset is set at the installation time by the user.
@jlind23 I think dynamic dataset name in input packages was not considered to be supported by this enhancement. We could come up with a way to support it (in a new issue?), though it's tricky as the dataset name can be anything. E.g. use a wildcard to map to any dataset name under custom_logs input package
- source_dataset: k8s.router
rules:
- target_dataset: custom_logs.*
if: "true == true"
What about this one: https://github.com/elastic/package-spec/issues/566 ?
What about this one: elastic/package-spec#566 ?
We can use that issue to add support for routing rules in input packages, that looks like a use case for local routing rules, not injected.
See my comment on the other issue - I'm skeptical that we need routing rules in input packages at all.
@kpollich Can this be closed or is there an aspect of this not implemented yet?
Ref https://github.com/elastic/package-spec/issues/514 Follow-up from https://github.com/elastic/kibana/issues/155910
When integrations are installed, Fleet should honor all injected routing rules defined by a given data stream manifest in addition to all local rules. The local rules support is handled by https://github.com/elastic/kibana/issues/155910
Given a data stream manifest as follows
The ingest pipelines for the
k8s.router
andsyslog
datastreams should be updated as followsOne important detail to note: injected routing rules always appear AFTER local routing rules for a given data stream. This prevent unintended short-circuiting.