search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.75k stars 8.15k forks source link

[Lens] deprecated property being added to Lens SO #163656

Open drewdaemon opened 1 year ago

drewdaemon commented 1 year ago

Kibana version: 8.9

Describe the bug: New Lens visualizations are being saved with the datasourceStates.indexpattern key in the saved object.

Steps to reproduce:

  1. Create a new Lens vis
  2. Save it
  3. View the saved object

Expected behavior:

The only two valid datasources are formBased and textBased. There shouldn't be any indexpattern.

Any additional context: Could be related to this fix: https://github.com/elastic/kibana/pull/160129/

elasticmachine commented 1 year ago

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula commented 1 year ago

I cant replicate it, I just created a Lens viz and it is saved with formbased. Can you share the steps you followed?

drewdaemon commented 1 year ago

I just replicated it on our 8.9 cloud instance.

Screenshot 2023-08-11 at 9 42 24 AM
stratoula commented 1 year ago

Oh I see what you say but the active datasource is the formBased which is the correct one. I will change it to tech dept

dej611 commented 1 year ago

I think this is related to https://github.com/elastic/kibana/pull/160129 . It could be cleaned up better on saving.