[ES|QL] [Discover] Removes the suggestion selector

[stratoula]

Describe the feature: In 8.11+ we introduced a suggestion dropdown on the unified histogram plugin, in the cases where the user is visualizing an ES|QL query with stats / keep.

On https://github.com/elastic/kibana/pull/175227 we decided to remove the suggestions selector:

• it adds complexity to our code without any reason
• it adds some UX confusion especially when the user has selected a suggestion but then changes the chart type from the flyout to something else.

The lens inline editing flyout has already this functionality. We are going to use this instead. In order to do so we need:

• Remove the hidesSuggestions property from the Unified histogram ChartConfigPanel
• Remove this https://github.com/elastic/kibana/blob/main/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx#L358. Now we don't need extra handling for Discover. We only want to hide the ES|QL query editor but this is already handled here https://github.com/elastic/kibana/blob/main/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx#L430. The unified histogram will still report the canEditTextBasedQuery as false (or omit it, by default is false)
• Unified histogram ChartConfigPanel needs to add an additional property the updateSuggestion. An example can be seen here https://github.com/elastic/kibana/blob/main/x-pack/plugins/lens/public/embeddable/embeddable.tsx#L812. So it should look like

<Component
          attributes={visContext.attributes}
          updatePanelState={updatePanelState}
          updateSuggestion={newCallback}
          lensAdapters={lensAdapters}
          output$={lensEmbeddableOutput$}
          displayFlyoutHeader
          closeFlyout={() => {
            setIsFlyoutVisible(false);
          }}
          wrapInFlyout
          datasourceId="textBased"
        />

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[stratoula]

Adding impact: high as I hope it will get prioritized cc @davismcphee @jughosta

[jughosta]

@stratoula I'm think about still setting hidesSuggestions to true for ES|QL histogram mode as we are using a different underlying query for this chart.

So if query is from logs* | limit 10, then hide suggestions in the flyout. The underlying query is from kibana_sample_data_logs | limit 10 | EVAL timestamp=DATE_TRUNC(24 hour, @timestamp) | stats results = count(*) by timestamp | rename timestamp as "@timestamp every 24 hour".

If query is from logs* | limit 10 | stats var0 = avg(bytes) by extension.keyword, then allow to use suggestions in the flyout.

Is that okay?

[stratoula]

Yes totally! Good catch, I had mostly in mind the charts that the suggestion selector is being rendered!