Closed harshitgupta-qasource closed 5 months ago
Pinging @elastic/fleet (Team:Fleet)
@amolnater-qasource Kindly review
Secondary review for this ticket is Done
@jillguyonnet This tooltip only kicks in for POLICY_CHANGE
actions and not POLICY_REASSIGN
(such as the first action in the above screenshot). Do you think it makes sense to apply it to both?
LOC for future reference: https://github.com/elastic/kibana/blob/980d8bf3012265c2c2da6d695ace343d3d1f8d80/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout/view_agents_button.tsx#L53
Hey @jen-huang 👋
It seems to me that the current behaviour is correct, i.e. that this tooltip is only relevant for policy change events.
View agents
button correctly filters for the agents that were reassigned at the time of the change. This is because these change events are done at agent level and contain the information of which agent(s) were affected. Therefore, this tooltip would provide incorrect information.POLICY_CHANGE
), the change events are generated on the fly from the policy data and contain no such history. This implies that the filtering is done for agents currently assigned (i.e. at the time when the flyout is opened), which may differ from the ones who were assigned at the time of the change. While this is probably not completely ideal, it is a known case and the reason why this tooltip was added for this type of change.The above can be validated as follows.
Agent policy 1
.Agent policy 2
.Agent policy 2
. Wait until the reassign is complete.Agent policy 2
. Wait until the reassign is complete.1 agent assigned to a new policy
. When clicking the View agents
button, the oldest event should filter for the first agent only, the newest event should filter for the second agent only.Agent policy 1
and the other assigned to Agent policy 2
.Agent policy 1
and save the policy.1 agent applied policy change
. When clicking the View agents
button, it should filter for the first agent.Agent policy 2
. Wait until the reassign is complete.2 agents applied policy change
(instead of 1 agent
). When clicking the View agents
button, it will now filter for both agents.Hope this helps, let me know if anything is unclear.
Thanks for the clarification Jill! This helps a lot.
@harshitgupta-qasource @amolnater-qasource I will close this as expected behavior based on Jill's notes above. The reassignment action shown in your video is not expected to have a tooltip.
Thank you for confirming the expected behavior and we will update our test content accordingly. Thanks
Kibana Build details:
Host OS: All
Preconditions:
Steps to reproduce:
Expected Result: Tooltip should be available on the "View agents" under Agent Activity of changed Policy.
Screen Recording:
https://github.com/elastic/kibana/assets/101545338/1d424e11-d8b5-49d4-ad8a-b8f734fd11e9
Feature:
https://github.com/elastic/kibana/issues/153232