[Security Solution] Tests for prebuilt rule upgrade workflow

[banderror]

Epics: https://github.com/elastic/security-team/issues/1974 (internal), https://github.com/elastic/kibana/issues/174168

Summary

Write test plans (one or a few) and create a comprehensive suite of automated tests for the workflow of upgrading prebuilt rules.

Features to cover:

• API: upgrade/_review and upgrade/_perform endpoints
• Upgrading prebuilt rules one-by-one with preview (Rule Upgrade flyout)
  • Non-conflicts, solvable conflicts, non-solvable conflicts
  • Diffs and diff options
  • Suggesting merged versions
  • Editing and accepting changes to the Final version
  • Callouts
  • Validation
  • State persistence
  • Upgrading and saving changes
  • Anything else?
• Upgrading prebuilt rules one-by-one without preview (Rule Updates table)
• Upgrading prebuilt rules in bulk (Rule Updates table)
• Upgrading rule fields - per each rule field - via API and UI
  • name
  • description
  • etc - I feel that we need to cover literally every rule field
• Specific and edge cases
  • Type changes on upgrade
  • Missing base versions
  • Race conditions and Optimistic Concurrency Control

Please cover both the features under the feature flag turned ON and OFF.

Related tickets

Related functional tickets to cover with tests:

• API
  • https://github.com/elastic/kibana/issues/180153
  • https://github.com/elastic/kibana/issues/180393
  • https://github.com/elastic/kibana/issues/166376
  • https://github.com/elastic/kibana/issues/186544
  • https://github.com/elastic/kibana/issues/190597
  • https://github.com/elastic/kibana/issues/196213
• UI
  • https://github.com/elastic/kibana/issues/180589
  • https://github.com/elastic/kibana/issues/171520
  • https://github.com/elastic/kibana/issues/188065
  • https://github.com/elastic/kibana/issues/180395

Related bugs to cover with tests:

• https://github.com/elastic/kibana/issues/180195
• https://github.com/elastic/kibana/issues/200904
• https://github.com/elastic/kibana/issues/201500
• https://github.com/elastic/kibana/issues/200811
• https://github.com/elastic/kibana/issues/200286
• https://github.com/elastic/kibana/issues/200134
• Anything else from Milestone 3 bugs under the corresponding section

TODO

• [ ] Come up with a plan for working on this ticket and share with the team
• [ ] Test plans
  • [ ] PR link
• [ ] Test coverage
  • [ ] PR link

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[elasticmachine]

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

[banderror]

@jpdjere @maximpn @nikitaindik

I'd suggest us to split the work on the upgrade test coverage between @maximpn and @jpdjere. Considering the fact that @maximpn and @nikitaindik are busy with finalizing the ThreeWayDiff UI and fixing bugs in it, maybe @jpdjere could address most of this ticket, especially because he is very familiar with the requirements.

Let's sync up on it when @jpdjere is back next week.

[banderror]

cc @pborgonovi