elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.01k stars 8.25k forks source link

🌊 Streams: Processing for classic streams #202339

Closed flash1293 closed 2 days ago

flash1293 commented 2 weeks ago

This PR allows to add processing to classic streams.

When defining processing for a classic stream, it will add a reference to the <stream name>@stream.processing pipeline to the default pipeline of the stream (or a @custom sub pipeline if it exists). Then, it will write processing rules like for wired streams.

On the UI, the processing tab is not implemented yet, but this PR also prepares that there are two tabs (overview and enrich) shown for classic streams, not just an overview page.

flash1293 commented 4 days ago

Thanks @simianhacker - added that:

Screenshot 2024-12-09 at 14 53 46

I also extended the logic a bit to clean up the processor in the user-managed pipeline if the stream gets deleted so the user has a safe way to get rid of it.

Should be good for another look.

I will add some integration tests for this on a follow-up PR.

elasticmachine commented 2 days ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 149 152 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 95.5KB 96.1KB +587.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
streams 4 3 -1

History

kibanamachine commented 2 days ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12275394441

kibanamachine commented 2 days ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation