elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.01k stars 8.25k forks source link

[Fleet] Support input variable for integrations package #202362

Closed nchaulet closed 1 week ago

nchaulet commented 2 weeks ago

Summary

Input variables used to not be available for integrations package, it seems the support for the UI editor is already done probably with https://github.com/elastic/kibana/issues/194310

That PR add the support so the package API, will support it too.

Test

I added unit test to cover that change,

You can test this with the elastic_conector package (in prerelease)

POST kbn:/api/fleet/package_policies
{
  "package": {
    "name": "elastic_connectors",
    "version": "0.0.4"
  },
  "name": "elastic_connectors-2",
  "namespace": "",
  "description": "",
  "policy_ids": [
    "fleet-server-policy"
  ],
  "vars": {},
  "inputs": {
    "github-connectors-py": {
      "enabled": true,
      "vars": {
        "connector_name": "my-test-connector",
        "connector_id": "123456"
      },
      "streams": {}
    },
    "google_drive-connectors-py": {
      "enabled": true,
      "vars": {
        "connector_name": "test",
        "connector_id": "tata"
      },
      "streams": {}
    }
  }
}
elasticmachine commented 1 week ago

Pinging @elastic/fleet (Team:Fleet)

elasticmachine commented 1 week ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 173.4KB 173.4KB -4.0B

History

cc @nchaulet

kibanamachine commented 1 week ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12120093534

kibanamachine commented 1 week ago

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation