elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.01k stars 8.25k forks source link

[Collapsable panels][A11y] Tabbing through panels in a correct order #202365

Closed mbondyra closed 1 week ago

mbondyra commented 1 week ago

Summary

This is a preparatory step for keyboard navigation improvements.

It ensures proper tabbing order by aligning grid positions with the sequence in the HTML structure, as recommended for accessibility. Manipulating the tabindex property is an alternative but it's not a good approach. Keeping grid layouts consistent with the HTML flow is a more sustainable and accessible approach, as outlined in related documentation.

https://github.com/user-attachments/assets/d41eac8d-1ee1-47b1-8f40-e3207796573b

I also modified styles for drag and resize handles.

hover:

Screenshot 2024-11-29 at 20 47 13

focus:

Screenshot 2024-11-29 at 20 47 40
elasticmachine commented 1 week ago

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/grid-layout 1 2 +1

History

kibanamachine commented 1 week ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12175687085

kibanamachine commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation