elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.01k stars 8.25k forks source link

[OpenAPI] Fix Serverless API base URL #202373

Closed lcawl closed 1 week ago

lcawl commented 1 week ago

Summary

Fixes https://github.com/elastic/docs-content/issues/153

In particular, it removes unnecessary server URL declarations from some SLO API files and updates the kibana API overlays so that the serverless API document is no longer referring to "localhost".

NOTE: Per https://spec.openapis.org/oas/v3.0.3#server-object the "default" value is required.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

No

Screenshots

The Kibana Serverless API examples will look like this:

image

The Kibana API examples will look like this:

image

elasticmachine commented 1 week ago

Pinging @elastic/kibana-docs (Team:Docs)

elasticmachine commented 1 week ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions[bot] commented 1 week ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine commented 1 week ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

βœ… unchanged

History

kibanamachine commented 1 week ago

Starting backport for target branches: 8.16, 8.17

https://github.com/elastic/kibana/actions/runs/12127137280

kibanamachine commented 1 week ago

πŸ’” All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [Synthetics] Fix to handle ops genie as default connector !! (#201923)
- [Stack Connectors][SentinelOne + Crowdstrike] Update Crowdstrike and Sentinelone connectors to NOT validate API responses (#202515)
❌ 8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- [Synthetics] Fix to handle ops genie as default connector !! (#201923)
- [Stack Connectors][SentinelOne + Crowdstrike] Update Crowdstrike and Sentinelone connectors to NOT validate API responses (#202515)
- [Security solution] Remove legacy ESQL quick prompt (#201276)
- [Security Solution] [Onboarding] t1_analyst role blocked from interacting with cards due to missing integration privileges (#202413)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202373

Questions ?

Please refer to the Backport tool documentation

lcawl commented 1 week ago

πŸ’š All backports created successfully

Status Branch Result
βœ… 8.x
βœ… 8.17
βœ… 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine commented 1 week ago

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.