search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.16k stars 8.28k forks source link

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting-explore` #202852

Closed gsoldevila closed 1 month ago

gsoldevila commented 1 month ago

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

[!IMPORTANT]

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
    • customised eslint rules
    • docs pointing to source code

[!NOTE]

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

1 plugin(s) are going to be relocated:

Id Target folder
@kbn/ecs-data-quality-dashboard-plugin x-pack/solutions/security/plugins/ecs_data_quality_dashboard

8 packages(s) are going to be relocated:

Id Target folder
@kbn/cell-actions src/platform/packages/shared/kbn-cell-actions
@kbn/ecs-data-quality-dashboard x-pack/solutions/security/packages/ecs_data_quality_dashboard
@kbn/security-solution-features x-pack/solutions/security/packages/features
@kbn/security-solution-navigation x-pack/solutions/security/packages/navigation
@kbn/security-solution-side-nav x-pack/solutions/security/packages/side_nav
@kbn/security-solution-storybook-config x-pack/solutions/security/packages/storybook/config
@kbn/security-solution-upselling x-pack/solutions/security/packages/upselling
@kbn/securitysolution-ecs src/platform/packages/shared/kbn-securitysolution-ecs
Updated references ``` ./.eslintrc.js ./.i18nrc.json ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/storybook/aliases.ts ./src/platform/packages/shared/kbn-cell-actions/jest.config.js ./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js ./yarn.lock ```
Updated relative paths ``` src/platform/packages/shared/kbn-cell-actions/jest.config.js:12 src/platform/packages/shared/kbn-cell-actions/tsconfig.json:2 src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12 src/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2 x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15 x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12 x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2 ```
github-actions[bot] commented 1 month ago

A documentation preview will be available soon.

Request a new doc build by commenting * Rebuild this PR: `run docs-build` * Rebuild this PR and all Elastic docs: `run docs-build rebuild` `run docs-build` is much faster than `run docs-build rebuild`. A `rebuild` should only be needed in rare situations. If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status [here](https://buildkite.com/elastic/docs-build).
elasticmachine commented 1 month ago

Pinging @elastic/kibana-core (Team:Core)

elasticmachine commented 1 month ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

elasticmachine commented 1 month ago

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

elasticmachine commented 1 month ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

kibanamachine commented 1 month ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12321534800

kibanamachine commented 1 month ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12321534711

kibanamachine commented 1 month ago

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202852

Questions ?

Please refer to the Backport tool documentation

kibanamachine commented 1 month ago

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202852

Questions ?

Please refer to the Backport tool documentation

gsoldevila commented 1 month ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine commented 1 month ago

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.