elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.15k stars 8.27k forks source link

[Ownership] Add code owner to ftr failure report #203076

Closed wayneseymour closed 1 month ago

wayneseymour commented 1 month ago

Summary

Resolves: https://github.com/elastic/kibana/issues/202687

For Reviewers

To test locally, make a test fail, something like

diff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts
index 0e29b29e96e..78976e6d54b 100644
--- a/test/functional/apps/console/_autocomplete.ts
+++ b/test/functional/apps/console/_autocomplete.ts
@@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.console.setAutocompleteTrace(false);
     });

-    it('should provide basic auto-complete functionality', async () => {
+    it.only('should provide basic auto-complete functionality', async () => {
       await PageObjects.console.enterText(`GET _search\n`);
       await PageObjects.console.pressEnter();
       await PageObjects.console.enterText(`{\n\t"query": {`);
       await PageObjects.console.pressEnter();
       await PageObjects.console.sleepForDebouncePeriod();
       await PageObjects.console.promptAutocomplete();
-      expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
+      expect(false).to.be.eql(true);
     });

     it('should not show duplicate suggestions', async () => {

Then run the tests:

TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests --config=test/functional/apps/console/config.ts --bail

Then run the reporter to see the html file

JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml' --no-github-update --no-index-errors

Lastly, inspect the HTML File

grep elastic target/test_failures/*.html -B 2

            <div>
                <strong>Owners</strong>:
                <pre>elastic/kibana-management</pre>
--
            </div>
            <div>
                     <a href="https://github.com/elastic/kibana/issues/156926">https://github.com/elastic/kibana/issues/156926</a>
--
              <h5>Stdout</h5>
              <pre>Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926

Notice the <pre>elastic/kibana-management</pre> in the output of grep

Also, you can continue verification of the ownership value, via: node scripts/get_owners_for_file.js --file test/functional/apps/console/_autocomplete.ts

 succ Found matching entry in .github/CODEOWNERS:
      test/functional/apps/console/*.ts elastic/kibana-management
wayneseymour commented 1 month ago

@elasticmachine merge upstream

wayneseymour commented 1 month ago

@elasticmachine merge upstream

wayneseymour commented 1 month ago

@elasticmachine merge upstream

elasticmachine commented 1 month ago

:green_heart: Build Succeeded

Metrics [docs]

āœ… unchanged

History

cc @wayneseymour

wayneseymour commented 1 month ago

šŸ’š All backports created successfully

Status Branch Result
āœ… 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation