[Dataset Quality] Reclassify modules as "platform/shared"

weltenwort commented 1 month ago

:memo: Summary

This reclassifies the plugins @kbn/data-quality-plugin and @kbn/dataset-quality-plugin as platform/shared, because they're not specific observability despite the code ownership.

partly addresses: https://github.com/elastic/observability-dev/issues/4059

:female_detective: Review notes

One small utility hook was copied from @kbn/observability-shared-plugin to remove a forbidden dependency.

weltenwort commented 1 month ago

@gbamparop thanks for the review, but this is not done yet :innocent:

elasticmachine commented 1 month ago

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

github-actions[bot] commented 1 month ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

weltenwort commented 1 month ago

@elasticmachine merge upstream

elasticmachine commented 1 month ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 4451aba200ee13cfbfd57ddbf8b88a587701c403
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204052-4451aba200ee

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`datasetQuality`	278	273	-5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`datasetQuality`	252.5KB	252.5KB	-34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`datasetQuality`	18.9KB	18.9KB	+20.0B

History

:green_heart: Build #261529 succeeded 2f92d569672f94057fe3dccdff472c931bfcdbf1
:broken_heart: Build #260464 failed f7be89d6f584a7fab1f1c3c5e780b50c5bcafd46
:broken_heart: Build #260004 failed 338b0f09bc35abe8570db9bd2c42c718b429238d
:broken_heart: Build #259988 failed a63113fa3c19baafe6529b07c2937ded68c08f1c

cc @weltenwort

kibanamachine commented 1 month ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12400585629

kibanamachine commented 1 month ago

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204052

Questions ?

Please refer to the Backport tool documentation

elastic / kibana