elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.16k stars 8.28k forks source link

[Observability plugin] Audit new EUI Borealis theme #204234

Closed fkanout closed 1 month ago

fkanout commented 1 month ago

Summary

It fixes #203338

Note

Some of the tokens have been ignored as they were on the server side or common folder, or they are coming from a shared package like packages/react/kibana_context

elasticmachine commented 1 month ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

fkanout commented 1 month ago

/oblt-deploy

elasticmachine commented 1 month ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

github-actions[bot] commented 1 month ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine commented 1 month ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1922 1929 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.3MB 3.4MB +9.6KB
infra 1.7MB 1.7MB -78.0B
synthetics 1.1MB 1.1MB +18.0B
total +9.6KB

History

cc @fkanout

fkanout commented 1 month ago

@kdelemme @mgadewoll This PR seems to overlap with other ones scope-wise. I discussed this with @jasonrhodes, and we agreed to scope this PR to update only the files that are owned by our team. Sorry about letting you double-review this work. But the new PR is significantly smaller. I appreciate your help!

patpscal commented 1 month ago

Hi @fkanout! To make our design review as helpful as possible, could you share from a final user's perspective where they might notice the changes (in case it impacts the user)?

fkanout commented 1 month ago

closing this in favor of https://github.com/elastic/kibana/pull/204615/