elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
20.14k stars 8.27k forks source link

[User] Prevent disabled input change by password manager #204269

Closed nickofthyme closed 1 week ago

nickofthyme commented 1 month ago

Summary

Prevents username input from being edited by password manager extensions when disabled.

Zight Recording 2024-12-13 at 12 08 06 PM

fixes #204268

Checklist

nickofthyme commented 1 week ago

@elastic/kibana-security could I get another look at this? Thanks!

nickofthyme commented 1 week ago

Good point @jeramysoucy. Added test in f2ab08d79819974c9c217fd1d00387226fcf5643.

elasticmachine commented 1 week ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 543.3KB 543.3KB +13.0B

History

kibanamachine commented 1 week ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12699786102

kibanamachine commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation