search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

Support International English (UK English) #93893

Open jaapie opened 3 years ago

jaapie commented 3 years ago

I am from a country that uses UK English. I would like to be able to have that language as an option in the Kibana UI. I am happy to attempt to contribute a pull request with whatever is needed by Kibana to get this happening.

I have no familiarity with the codebase so can someone please point me in the right direction?

elasticmachine commented 3 years ago

Pinging @elastic/kibana-localization (Team:Localization)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-core (Team:Core)

Bamieh commented 3 years ago

Hey @jaapie thanks for opening this issue!

Currently we do not accept any translation changes from any source except our translators. We do not have a reliable way to ensure the quality of the translated strings so relying on one source of truth helps keeping the translations consistent at the very least.

We can keep this issue open as a tracker to see if it gets enough community traction for us to prioritise.

We do support extending i18n.locales by creating an external plugin and providing all kibana's locale ids through the plugin (using the Extract default message tool.

Link to docs here: https://www.elastic.co/guide/en/kibana/master/external-plugin-localization.html

I would like to be able to have that language as an option in the Kibana UI

Currently locales can be only specified from the kibana config before kibana start.

jaapie commented 3 years ago

Thanks for that explanation; I can see how your process would ensure the overall quality and consistency of Kibana/Elastic, but it's pretty limiting as well. It would only require very minor changes, changing for example -or to -our and -ize to -ise (off the top of my head) where needed.

Bamieh commented 3 years ago

@jaapie I'm wondering if a package like this: https://github.com/hyperreality/American-British-English-Translator#readme would be enough to support UK english in kibana

jaapie commented 3 years ago

I think it would be used to identify spelling issues rather than fixing them on the fly (if that's what you were hoping). At the least it would help build a new English (UK) internationalisation file.