elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.15k forks source link

Licensing plugin should not provide user-facing messages #99754

Open mshustov opened 3 years ago

mshustov commented 3 years ago

Licensing plugin provides translated error messages https://github.com/elastic/kibana/blob/4584a8b570402aa07832cf3e5b520e5d2cfa7166/x-pack/plugins/licensing/common/license.ts#L106-L130 Plugins show them in logs and UI. These messages often can be misleading since they are created out of plugin-specific context https://github.com/elastic/kibana/issues/95032 We should remove them from licensing plugin and refactor plugin to provide their own messages

List of plugin relying on licensing.check().message:

elasticmachine commented 3 years ago

Pinging @elastic/kibana-core (Team:Core)