elastic / ml-cpp

Machine learning C++ code
Other
7 stars 62 forks source link

[ML] Change time shift sign for intuitive configuration #2737

Closed valeriy42 closed 2 months ago

valeriy42 commented 2 months ago

The way the application of the force_time_shift custom rule was configured before, is to specify the amount of time the model's frame of reference should shift by.

This is counter-intuitive for the users, since in spring when they need to move their clock forward, they would be expected to specify force_time_shift by -3600, aka backward.

This PR switches the sign inside the C++ implementation and allows a more intuitive configuration.

I marked it as a non-issue since the functionality has not yet been released.