Closed eedugon closed 1 week ago
@rogercoll , or @gizas : I'd like you to review this PR and let me know if there are other configuration settings you believe we should include for customers to consider customizing when installing the operator.
Should we add or describe the default resources used by the operator for the collectors?
Also, what about this sentence?
The
namespace
of the installation cannot be changed and must be set toopentelemetry-operator-system
during the helm chart installation.
Is it accurate? I've added it because I tried to customize the namespace directly in the helm install
command and the installation failed, so I guess we might have the namespace defined somewhere else in the chart.
If we need to support installation in a different namespace we should probably create a separate issue for it.
Line 145: $ helm upgrade --install --namespace opentelemetry-operator-system opentelemetry-kube-stack open-telemetry/opentelemetry-kube-stack --values ./resources/kubernetes/operator/helm/values.yaml --version 0.3.0
Please Update the version to --version 0.3.3
thanks @gizas ! I'll apply the suggested changes :)
I am little worried with the compatibility matrix that we can forget to update as we upgrade the versions. Can we make sure that we make this update part of DoD somewhere or automation step?
The link Values files are available in the resources directory points to a custom reference, I would say to link it with main
Also in the matrix can you update the 8.16.0 values.yaml to have a link to https://github.com/elastic/opentelemetry/blob/8.16/resources/kubernetes/operator/helm/values.yaml and the chart version to be 0.3.3 !!!
For additional things to describe, I would say for now we are ok. I will let other to comment on this
For the namespace I did a smoke test and worked for me
User needs to:
But I agree lets create a new issue to test namespace change. And for now lets remove any reference to namespace configuration. WDYT?
@gizas , thanks a lot for your comments!
For all the values.yaml
related comments I was going to address that in a different PR (as soon as it was clear where exactly the values file is published), but I think I can manage it on this PR too.
Replying inline:
I am little worried with the compatibility matrix that we can forget to update as we upgrade the versions. Can we make sure that we make this update part of DoD somewhere or automation step?
Good point, let's discuss it in a different issue. I will create one.
The link Values files are available in the resources directory points to a custom reference, I would say to link it with main Also in the matrix can you update the 8.16.0 values.yaml to have a link to https://github.com/elastic/opentelemetry/blob/8.16/resources/kubernetes/operator/helm/values.yaml and the chart version to be 0.3.3 !!!
Perfect, I'll work on that on this PR as it's a small and needed change.
For the namespace I did a smoke test and worked for me
Cool, I'm removing then the NOTE
about not being supported and we can add the procedure to change the namespace in a different issue + PR (if we have a way to not hardcode the namespace in the values.yaml
that would be ideal :) ).
Thanks a lot for your help!
Changes implemented @gizas , feel free to take a look.
Added the following sub-sections to Kubernetes onboarding documentation 👍
publicly trusted
statement, as even if cert-manager is used the certificate will still beself-signed
(although automatically renewed).I'll be requesting in this PR first a review by docs team and then by product team (@rogercoll / @gizas / @mlunadia ).
Closes https://github.com/elastic/opentelemetry/issues/35