search

elastic / package-spec

EPR package specifications
Other
17 stars 70 forks source link

Deprecate dependencies.ecs.import_mappings #726

Closed zmoog closed 5 months ago

zmoog commented 5 months ago

What does this PR do?

Deprecate dependencies.ecs.import_mappings

Why is it important?

Starting from stack version 8.13, Fleet adds the ecs@mappings component template to all index templates. With the ecs@mappings, integration no longer need to use the static legacy mappings embedded by elastic-package at build time.

Checklist

Related issues

zmoog commented 5 months ago

I plan to stop importing the legacy mappings on integrations that opt-in to the package-spec release (3.2?) containing this change.

However, I also want to allow packages using 2.3 < spec < 3.2 to continue using it as before.

@jsoriano, what’s the correct workflow to sunset dependencies.ecs.import_mappings? Should we only deprecate it or remove it? Do you know past PRs I can use for reference?

jsoriano commented 5 months ago

@jsoriano, what’s the correct workflow to sunset dependencies.ecs.import_mappings? Should we only deprecate it or remove it? Do you know past PRs I can use for reference?

As discussed over slack, I would prefer to only deprecate it. This will continue being needed for packages using spec >= 3.2 and supporting versions of the stack < 8.13.

elasticmachine commented 5 months ago

:green_heart: Build Succeeded

History

cc @zmoog