search

elcuervo / minuteman

Fast analytics using Redis
elcuervo.github.com/minuteman
MIT License
629 stars 63 forks source link

Feature/allow use of mock redis #10

Closed awsmsrc closed 10 years ago

awsmsrc commented 10 years ago

I wanted to use MockRedis in our test environment.

MinuteMan was checking the class of the passed in Redis object and instantiating a Redis object if it wasnt of type Redis

Not specifying this allows for passing in mock objects and potentially other data stores.

This pr still accepts a hash of options, instantiates a new redis client if none was passed or simply uses what the programmer specifies

I had to specify a redis var on the Minuteman class in the test helper.

I think the specified redis is not being used in operation.rb as that is a class level var? But in all honesty I havent had much time to test that theory. and it seems like a different issue to my use case.

PS, Thanks for the awesome gem! This has given us some great insight at work!

elcuervo commented 10 years ago

Awesome. I'm going to take a look. I'm currently off the grid. I'm working aon a brand new release. Would you like to discuss some of the new features?

awsmsrc commented 10 years ago

For sure, I really wanna get involved in more open source projects! Definitely time to give back. I work remotely and don't have set hours at work so hit me up when ever is good for you

awsmsrc commented 10 years ago

hi @elcuervo, any updates? Feel free to tell me to leave you alone ;)

elcuervo commented 10 years ago

Not at all! I've been off the grid. I'll look at it today. I promise. :)

On 04/01/2014, at 20:36, lukeroberts1990 notifications@github.com wrote:

hi @elcuervo, any updates? Feel free to tell me to leave you alone ;)

— Reply to this email directly or view it on GitHub.