search

elcuervo / minuteman

Fast analytics using Redis
elcuervo.github.com/minuteman
MIT License
629 stars 63 forks source link

Gem maintenance #35

Closed toadkicker closed 5 years ago

toadkicker commented 5 years ago

Greetings,

Thanks for this great gem, really enjoyed reading through the code today and understanding it more. I wanted to get it up to date and address issue #31. I found a couple spelling errors and fixed them in the readme/license. Last is a run on rubocop to fix up things like single quotes where no interpolation is performed, etc.

Hope this is helpful and look forward to your feedback.

elcuervo commented 5 years ago

Thank you very much for the PR. It remind me about a community I loved. My life took unexpected turns that made me go away for some time, too much time.

This simple act of sending code to something I built was enough to get me back to a place I once called home.

I took some of the comments you made to update the gem and make the tests green.

Thank you, thank you very much