search

electrickery / pd-tof

Collection of control and signal objects by Thomas Ouellet Fredericks, previously part of Pd-extended
Other
5 stars 0 forks source link

menubutton: floats not working in v.0.2.2 #2

Open oliverstotz opened 4 years ago

oliverstotz commented 4 years ago

i just discovered a bug in the [menubutton] object of the TOF library, in version 0.2.2

if you send a float to the [menubutton] object to recall an item by index (or also if you just want to "set" it with a float), it is always interpreted as 0, no matter what the sent number was.

on the other hand, symbols work, also with the "set" method.

this bug wasn't there in TOF version 0.2.1, i checked it on PD 0.48 through 0.51 (both 32 and 64 bit versions)

Best

Oliver

menubutton_bug_120920.zip

electrickery commented 4 years ago

Hi Oliver,

Thanks for the bug report. It has been a while since I looked into the code, but I might have found the cause (menu_button.c:232).

I'll do some testing to make sure and then make a 0.2.3.

Greetings,

Fred Jan

i just discovered a bug in the [menubutton] object of the TOF library, in version 0.2.2

if you send a float to the [menubutton] object to recall an item by index (or also if you just want to "set" it with a float), it is always interpreted as 0, no matter what the sent number was.

on the other hand, symbols work, also with the "set" method.

this bug wasn't there in TOF version 0.2.1, i checked it on PD 0.48 through 0.51 (both 32 and 64 bit versions)

Best

Oliver

menubutton_bug_120920.zip https://github.com/electrickery/pd-tof/files/5212458/menubutton_bug_120920.zip

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/electrickery/pd-tof/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACXYQ7GXLAVY2OH5X6CCRTSFM3XNANCNFSM4RJIU32Q.

electrickery commented 4 years ago

Hi Oliver,

The new version is checked in into git, and packages are uploaded to puredata.info. It will take a day before they become visible/searchable from the "Find externals..." window, but you could try downloading directly from https://puredata.info/Members/fjkraan/software/tof/0.2.3/.

The problem was a cleanup typo caused by me.

I hope to do some testing today and announce it tomorrow on the list.

Greetings,

Fred Jan

i just discovered a bug in the [menubutton] object of the TOF library, in version 0.2.2

if you send a float to the [menubutton] object to recall an item by index (or also if you just want to "set" it with a float), it is always interpreted as 0, no matter what the sent number was.

on the other hand, symbols work, also with the "set" method.

this bug wasn't there in TOF version 0.2.1, i checked it on PD 0.48 through 0.51 (both 32 and 64 bit versions)

Best

Oliver

menubutton_bug_120920.zip https://github.com/electrickery/pd-tof/files/5212458/menubutton_bug_120920.zip

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/electrickery/pd-tof/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACXYQ7GXLAVY2OH5X6CCRTSFM3XNANCNFSM4RJIU32Q.

oliverstotz commented 4 years ago

Hi, I just tested with your linked update and everything seems to be fine now ! Thanks a lot !

Best

Oliver