search

electro-smith / json2daisy

Utility for converting JSON board definitions into valid, libDaisy compatible C++ board support files
MIT License
6 stars 1 forks source link

Replace any use of Print with logging instead. #3

Closed stephenhensley closed 2 years ago

stephenhensley commented 2 years ago

Not ideal to just have blanket level, printing as part of the module itself.

Logging can still be done for necessary stuff via the logging class.

CorvusPrudens commented 2 years ago

Actually, there isn't any printing. Exceptions are caught by the c2dsy.py script and reported after the build would otherwise complete. So for any issue within the script itself, I just raise some exceptions and the hvcc stuff already in place handles it nicely :)