electron-forge / electron-forge-docs

:electron: Mirror for Electron Forge's GitBook documentation
https://electronforge.io
83 stars 144 forks source link

Make some mention of the fact that the barrier to entry for auto-updates using github is 1000 dollars #183

Closed ChristopherJTrent closed 2 months ago

ChristopherJTrent commented 2 months ago

It'd be wonderful if there was some mention that in order to use github as an auto-update provider, one would have to spend over 1000 dollars per year to form an LLC and get an EV signing certificate, (llc required because fun fact, nobody will issue an EV key to an individual)

MarshallOfSound commented 2 months ago

It'd be wonderful if there was some mention that in order to use github as an auto-update provider, one would have to spend over 1000 dollars per year to form an LLC and get an EV signing certificate, (llc required because fun fact, nobody will issue an EV key to an individual)

This isn't true, on Windows you do not need a certificate in order to do auto updating. You never have. And if you want a certificate, you definitely don't need an EV one and you can definitely get certs for less than 1000 dollars.

On macOS you do and that costs 100 dollars a year but that's a requirement imposed by Apple and impacts everyone.

ChristopherJTrent commented 2 months ago

It'd be wonderful if there was some mention that in order to use github as an auto-update provider, one would have to spend over 1000 dollars per year to form an LLC and get an EV signing certificate, (llc required because fun fact, nobody will issue an EV key to an individual)

This isn't true, on Windows you do not need a certificate in order to do auto updating. You never have. And if you want a certificate, you definitely don't need an EV one and you can definitely get certs for less than 1000 dollars.

On macOS you do and that costs 100 dollars a year but that's a requirement imposed by Apple and impacts everyone.

Per your own documentation this is not true.

ChristopherJTrent commented 2 months ago

It'd be wonderful if there was some mention that in order to use github as an auto-update provider, one would have to spend over 1000 dollars per year to form an LLC and get an EV signing certificate, (llc required because fun fact, nobody will issue an EV key to an individual)

This isn't true, on Windows you do not need a certificate in order to do auto updating. You never have. And if you want a certificate, you definitely don't need an EV one and you can definitely get certs for less than 1000 dollars.

On macOS you do and that costs 100 dollars a year but that's a requirement imposed by Apple and impacts everyone.

Do you have any proof that an individual validation key will function for update.electronjs.org? They require signed code, hardline, so your comment that "you do not need a certificate to do auto updating" is not universally true.

MarshallOfSound commented 2 months ago

Do you have any proof that an individual validation key will function for update.electronjs.org? They require signed code, hardline, so your comment that "you do not need a certificate to do auto updating" is not universally true.

Hi, I helped write update.electronjs.org, I'm a core electron maintainer, I've written code for squirrel.mac and squirrel.windows.

There is no requirement on windows that your app be signed

Is there a poorly documented part of update.electronjs.org that indicates a code signing certificate is required on windows? The only platform that requires code signing is macOS and that is a platform level requirement, not an updater requirement

ChristopherJTrent commented 2 months ago

https://github.com/electron/electron/blob/main/docs/tutorial/code-signing.md

Also the Requirements section of the README here: https://github.com/electron/update.electronjs.org

MarshallOfSound commented 2 months ago

That would have been a better place to start that arriving in this repo all confrontational. You're lucky I engaged instead of ignoring or blocking.

I'll bring this issue to the electron docs group and get the website updated. But please in the future reconsider your approach to open source projects, being antagonistic is not the right communication strategy.

VerteDinde commented 2 months ago

@ChristopherJTrent, your comment was deleted as a violation of the Electron Code of Conduct. You may consider this an official warning.

Please do not interact with the project for 24 hours. After that, you're welcome to continue any issues or discussions as needed, as long as they fall within the code of conduct guidelines. I understand that working with open source software can be frustrating, but please be kind and civil to the people who are trying to help maintain that software.