search

electron / fiddle

:electron: 🚀 The easiest way to get started with Electron
https://electronjs.org/fiddle
MIT License
7.45k stars 692 forks source link

bisect should first narrow down to a range between two already-downloaded versions before downloading new versions #638

Open nornagon opened 3 years ago

nornagon commented 3 years ago

might help with this:

$ du -sh ~/Library/Application\ Support/Electron\ Fiddle/electron-bin
 21G    /Users/nornagon/Library/Application Support/Electron Fiddle/electron-bin
ckerr commented 3 years ago

I'm not sure about this. The idea makes intuitive sense and at first I gave it a thumbs-up, but I'm wondering who it is for?

If this is for manual human-driven bisection, the few minutes a maintainer spends running extra tests due to nonbinary bisection is probably more "expensive" than the cost of extra disk space.

If this is for autobisect... setups running autobisect are likely going to have most versions of Electron installed eventually, so it's more a case of "do we download this now, or do we download it later?" than of actually saving disk space.

As an alternative suggestion, I notice that the Electron zipfiles we download are about 40% the size of the unzipped content. Maybe there is some potential for saving disk space there.

nornagon commented 3 years ago

For human-driven bisection, I imagine the number of additional tests run will be small (probably 1–2 more than vanilla bisect, I suspect), and will be offset by reduced time waiting for Electron to download :)