electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 521 forks source link

Add metadata option to config of GCS publisher so headers such as cache-control can be set #3683

Closed Tobiasartz closed 2 months ago

Tobiasartz commented 2 months ago

Pre-flight checklist

Problem description

Using the GCS publisher I did not see a way of adding metadata to the GCS object. This causes files to revert to default metadata, including the cache-control header, which is set to a 3600 second default cache. RELEASES.json is affected by this header as well. I want my cache-header to be set to no-store so that I can push updates instantly and not have to wait for cache to expire.

Attached is a pull request that adds metadata as a config option. https://github.com/electron/forge/pull/3682

Proposed solution

This pull requests adds a metadata option to the config of the GCS publisher. https://github.com/electron/forge/pull/3682

Alternatives considered

I can go into GCS and update the metadata after every publish but I would rather set this on the bucket upload itself.

Additional information

No response

MarshallOfSound commented 2 months ago

Closed by #3682