search

electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 521 forks source link

deps(template-webpack-typescript): add `typescript` dependency #3696

Closed rtritto closed 2 months ago

rtritto commented 2 months ago

I can't reopen #3635

rtritto commented 2 months ago

Is there a reason we want to update the version of TypeScript here?

No, I only used the version ^4.6.3 of package.json in the root.

I did a search and only /packages/template/vite-typescript/tmpl/package.json use ~4.5.4; I can update it to ^4.6.3 or use the ~4.5.4 for packages/template/webpack-typescript/package.json and packages/template/webpack-typescript/tmpl/package.json

VerteDinde commented 2 months ago

Hey @rtritto, thanks for submitting a change, but I think we're going to reserve dependency changes to maintainers only. Thanks!