electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 521 forks source link

deps: fix webpack dependency #3697

Closed rtritto closed 2 months ago

rtritto commented 2 months ago

Summarize your changes:

Fix #3695

rtritto commented 2 months ago

FYI @MarshallOfSound

rtritto commented 2 months ago

fork-ts-checker-webpack-plugin use webpack (peer dependency) imply that webpack is auto installed by package manager as transitive peer depenedncy. All transitive peer dependencies must be used as dependencies or peer dependencies. An article written by author of yarn package manager: Implicit Transitive Peer Dependencies

webpack can be added once because it's a peer dependency.

rtritto commented 2 months ago

Maybe fork-ts-checker-webpack-plugin should use webpack as @electron-forge/plugin-webpack:

// packages/template/webpack-typescript/package.json and packages/template/webpack-typescript/tmpl/package.json
"devDependencies": {
  "webpack": "npm:@electron-forge/plugin-webpack@^7.4.0"
}
VerteDinde commented 2 months ago

Hey @rtritto, thanks for submitting a change, but I think we're going to reserve dependency changes to maintainers only. Thanks!