Closed rtritto closed 2 months ago
FYI @MarshallOfSound
fork-ts-checker-webpack-plugin
use webpack
(peer dependency) imply that webpack
is auto installed by package manager as transitive peer depenedncy.
All transitive peer dependencies must be used as dependencies or peer dependencies.
An article written by author of yarn package manager: Implicit Transitive Peer Dependencies
webpack
can be added once because it's a peer dependency.
Maybe fork-ts-checker-webpack-plugin
should use webpack
as @electron-forge/plugin-webpack
:
// packages/template/webpack-typescript/package.json and packages/template/webpack-typescript/tmpl/package.json
"devDependencies": {
"webpack": "npm:@electron-forge/plugin-webpack@^7.4.0"
}
Hey @rtritto, thanks for submitting a change, but I think we're going to reserve dependency changes to maintainers only. Thanks!
Summarize your changes:
@electron-forge/plugin-webpack
dependency movewebpack
to peer dependencies@electron-forge/template-webpack-typescript
dependency addwebpack
dependency (transitive peer dependency of@electron-forge/plugin-webpack
)Fix #3695