search

electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
558 stars 96 forks source link

Signing fails in Yarn PnP environments #283

Open connorworley opened 1 year ago

connorworley commented 1 year ago

osx-sign will attempt to pass a PnP zip path to codesign, which it can't read, resulting in an error:

WARNING: Code sign failed; please retry manually. Error: Command failed: codesign <snip> --entitlements /Users/connor.worley/Code/github.com/connorworley/karafriends/.yarn/cache/@electron-osx-sign-npm-1.0.4-aaf9a8f648-0d7382922e.zip/node_modules/@electron/osx-sign/entitlements/default.darwin.plist <snip>

It seems like copying the default entitlements files to a tmp directory and returning that path indefaultOptionsForFile would be a sufficient fix.

sibljon commented 10 months ago

I'm running into this very issue, and I can't get past it. Any ideas?

connorworley commented 10 months ago

I had to switch back to nodeLinker: node-modules :\

sibljon commented 10 months ago

Ahh, too bad. Thanks for the follow up!