search

element-hq / element-call

Group calls powered by Matrix
https://call.element.io
GNU Affero General Public License v3.0
596 stars 93 forks source link

EC doesn't disambiguate displaynames. #2746

Open ara4n opened 2 weeks ago

ara4n commented 2 weeks ago

Steps to reproduce

  1. Start an EC video call in a room with two different people called Matthew
  2. They both join
  3. There's no way to see which video comes from which user.

Outcome

What did you expect?

Like EW and EX (and all other Matrix clients should), users with the same-looking name should have their mxid appended after it in order to differentiate them from each other.

matrix-js-sdk should give us this almost for free via unhomoglyph - we just need to hook it up in the UX.

What happened instead?

Ambiguity and risk of impersonation.

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

hughns commented 2 weeks ago

It would be trivial to wire up the RoomMember.name property which disambiguates between all Matrix room members. However, I think in EC we would only want to disambiguate between current MatrixRTC call members. This is significantly more complicated to do as the view models need refactoring to get the right context in the right place.