search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.03k stars 1.96k forks source link

Flaky Percy tests due to variable dropdown size #24688

Closed andybalaam closed 8 months ago

andybalaam commented 1 year ago

Example - look at both the login screen and the Create Poll screen:

The size of the dropdowns on these screens seems to vary, causing Percy to object.

rec-2023-02-28_09 35 26

The above shows me clicking back and forth between the original and changed image in Percy. Note that the dropdown height seems to vary.

andybalaam commented 1 year ago

Example: https://percy.io/dfde73bd/matrix-react-sdk/builds/25531269/changed/1423277393?browser=edge&browser_ids=18%2C33%2C34%2C35&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=1024%2C1920

andybalaam commented 1 year ago

Example: https://percy.io/dfde73bd/matrix-react-sdk/builds/25532575/changed/1423330721?browser=edge&browser_ids=18%2C33%2C34%2C35&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1024&widths=1024%2C1920

luixxiul commented 1 year ago

Waiting to load items inside dropdown should fix the issue?

andybalaam commented 1 year ago

Waiting to load items inside dropdown should fix the issue?

That definitely sounds possible, even plausible.

andybalaam commented 1 year ago

Actually, some of these dropdowns are static lists of elements (e.g. on Login screen), so I don't think it's an async loading problem.

andybalaam commented 1 year ago

Not closed, just worked around by disabling test.

luixxiul commented 1 year ago

Other recent examples: https://percy.io/dfde73bd/matrix-react-sdk/builds/28207096/changed/

andybalaam commented 8 months ago

We are not using Percy any more. Closing this.