element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.03k stars 1.96k forks source link

Indicator of seek bar on audio player not reset to zero #24898

Closed luixxiul closed 5 months ago

luixxiul commented 1 year ago

Steps to reproduce

  1. Open a room
  2. Upload an audio file
  3. Play it and wait until the counter resets zero

Outcome

What did you expect?

The indicator of the seek bar should be reset to zero.

What happened instead?

It is reset to nearly zero, but not exactly. The position of the indicator slightly changes every time it resets, as the values --fillTo below show.

Screenshot from 2023-03-23 04-22-51 Screenshot from 2023-03-23 04-23-02

Both cases --fillTo and value are expected to be zero, unless intended.

The counter is reset to zero.

This issue essentially causes flaky Percy test reported here: https://github.com/vector-im/element-web/issues/24897

Operating system

Debian

Browser information

Firefox

URL for webapp

No response

Application version

develop branch

Homeserver

No response

Will you send logs?

No

alunturner commented 1 year ago

@luixxiul Good spot! Easily reproducible on the nightly build, have tagged as tolerable (from the user's perspective), but fixing anything that helps decrease flaky tests and improve developer experience is very helpful for us.

richvdh commented 1 year ago

When fixing this: note that the seek bar was disabled in Percy in order to stop it flaking out due to this bug. https://github.com/matrix-org/matrix-react-sdk/commit/5a1a91f16acfb4a314ca1b2564031a09b95f961f should be reverted once the bug is fixed.

t3chguy commented 5 months ago

Percy tests are gone