element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.04k stars 1.96k forks source link

`ToggleSwitch` on General user settings tab not aligned #25378

Closed luixxiul closed 1 year ago

luixxiul commented 1 year ago

Steps to reproduce

  1. Open General user settings tab
  2. Check Manage integrations
  3. Check https://percy.io/dfde73bd/matrix-react-sdk/builds/27420789/changed/1525422995

Outcome

What did you expect?

The toggle switch should be aligned.

What happened instead?

It is not aligned.

0

This is a regression by https://github.com/matrix-org/matrix-react-sdk/pull/10773/files#diff-f8e6af1703616cb291d8ad3bd78d1c132d4ee43591380e7002870771e90aef2fR23 of https://github.com/matrix-org/matrix-react-sdk/pull/10773

I expect this should be fixed once semantic headings are implemented on General user settings tab as well.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

luixxiul commented 1 year ago

https://percy.io/dfde73bd/matrix-react-sdk/builds/27420789/changed/1525423116 is due to the same change by https://github.com/matrix-org/matrix-react-sdk/pull/10773

kerryarchibald commented 1 year ago

Fixed by https://github.com/matrix-org/matrix-react-sdk/pull/10837 and https://github.com/matrix-org/matrix-react-sdk/pull/10794 (These changes were originally in one PR)