Percy test ` User settings tab - Preferences` and ` User settings tab - General` no longer capture all of the setting flags on the tab

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.04k stars 1.96k forks source link

Percy test ` User settings tab - Preferences` and ` User settings tab - General` no longer capture all of the setting flags on the tab #25391

Closed luixxiul closed 1 year ago

luixxiul commented 1 year ago

Steps to reproduce

Check https://percy.io/dfde73bd/matrix-react-sdk/builds/27461110/changed/1527545851

Outcome

What did you expect?

mx_SettingsTab should be captured.

What happened instead?

The dialog was captured instead.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

luixxiul commented 1 year ago

The same thing started to be observed for the General tab: https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$rr0aLusnMWWsEdvcRCZA9i6MNtXVKyOnlGlSdWBr7Ew?via=matrix.org&via=element.io&via=envs.net

kerryarchibald commented 1 year ago

cy.findByTestId and percySnapshotElement do not play together. percySnapshotElement uses jquery element.selector as the scope. When chained with a cy.get this is a selector and works fine, but for findByTestId is eg findByTestId(<testid>)