Flaky Percy test: Configured room on IRC layout - Githubissues

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.03k stars 1.96k forks source link

Flaky Percy test: Configured room on IRC layout #26151

Closed andybalaam closed 8 months ago

andybalaam commented 1 year ago

Steps to reproduce

E.g. this Percy test: https://percy.io/dfde73bd/matrix-react-sdk/builds/30076401/changed/1664921294?browser=chrome&browser_ids=47%2C48%2C49&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=120%2C260%2C285%2C500%2C1024%2C1920 failed with a spinner appearing instead of the date divider:

Outcome

What did you expect?

What happened instead?

kerryarchibald commented 11 months ago

https://percy.io/dfde73bd/matrix-react-sdk/builds/30602275/changed/1690802900?browser=firefox&browser_ids=47%2C48%2C49&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=original&width=1024&widths=264%2C580%2C796%2C1024%2C1920

kerryarchibald commented 11 months ago

Attempted a fix here: https://github.com/matrix-org/matrix-react-sdk/pull/11769 Should be disabled next time if that doesn't help as per https://handbook.element.io/books/web-app-team-wat/page/wat-flaky-test-policy

richvdh commented 8 months ago

seems like kerry's fix worked!