element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.04k stars 1.96k forks source link

Resampling algorithm used on client-side thumbnailing for e2e images is ugly #2769

Open ara4n opened 7 years ago

ara4n commented 7 years ago

Here's a really good example of awful image quality: combination of not using hidpi and using nearest-neighbour(?) resampling:

Screenshot 2020-01-22 at 15 39 49

keywords: filtering, resample, resize, lanczos, scaling, thumbnail

uhoreg commented 7 years ago

Another example, which is probably more obvious. (from https://matrix.to/#/!UCnwUWwIKhcpaPTHtR:sw1v.org/$14873254196120DQVBt:matrix.org) image Definitely looks like nearest-neighbour there.

ara4n commented 3 years ago

The Right Solution(tm) to this is probably https://github.com/nodeca/pica

ara4n commented 3 years ago

bumping up the severity as it's not really 'tolerable' to have spectacularly ugly thumbnails in an e2ee-by-default world. it's a concrete bug.

chronos1970 commented 2 years ago

I'd like to add that the avatar shown in the call panel does also have a very bad quality. However the avatar shown on the right panel doesn't seem to suffer from the same issue for some reason.

Clipboard01

t3chguy commented 2 years ago

That's unrelated, avatars aren't encrypted @chronos1970. Please file a relevant issue.

ara4n commented 3 months ago

It's still looking awful:

blob_vector___vector_0ac6459d-befd-4452-a465-c981034efec7

original being:

IMG_6819