element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.02k stars 1.96k forks source link

E2E device/key management dashboard to replace UnknownDeviceDialog #4522

Closed richvdh closed 1 year ago

richvdh commented 7 years ago

We are considering making a single crypto management dashboard, which would include:

You would open the dashboard by clicking on the padlock. [Not sure that this is very discoverable: we should probably put it elsewhere too?] [Absolutely. Room Settings? And linked from the dialog you get when you click on a per-msg padlock? --M]

We would then remove the Unknown Device Dialog, instead just showing the "couldn't send because unknown devices" error, and include a "click here to open dashboard" link. Ideally we would also show a "there are new devices in this room!" warning somewhere in the Room so that you can manage the list proactively.

Surely this can be the same StatusBar warning - the behaviour is just like losing connectivity. The second the untrusted devices appear, the warning appears in the StatusBar telling you messages will be queued until you verify them. If it's a single new unknown device, it'd be cute if the StatusBar warning just linked you straight to the verify dialog for that device though rather than forcing you unnecessarily through the dash -> this is now #5534



We might also replace the 'you got a keyshare request' dialog with a banner at the top of the app (where the 'new version of riot' banner goes) with 'You got a keyshare request! Click here to manage!' or 'A device has requested access to decrypt conversation history in the #foo:matrix.org room. Click here to manage!' -> this is now #5533



https://github.com/vector-im/riot-web/issues/4157 and https://github.com/vector-im/riot-web/issues/3857 have now been replaced by this one.

lampholder commented 7 years ago

Have we drawn any wireframes for how this would look? I would be happy to help with that - perhaps next Wednesday we can sketch some stuff on a whiteboard? Or do we need to move more quickly?

I've P2'ed this because I don't have much perspective on the E2E roadmap - please P1 if this is the next thing we're looking at :)

ara4n commented 7 years ago

P1'd 'cos it's the next thing we're looking at, and it's our biggest blocker on this stuff being usable in anger :)

richvdh commented 7 years ago

FTR it's just behind #2325 on my roadmap

AmandineLP commented 7 years ago

I won't be around for the sketching session, so here are some inputs. I also briefed Matthew:

Dashboard UI

image

Makes it easy to see any anomaly (ie wrong OS, wrong browser…)

New devices warning/verification management:

There are new devices in this room. It might be your contacts opening up a new browser window or someone stealing their account. You can disable this warning in this room, decide to send your message anyway (without verifying the devices) or verify all the new devices.

[ ] Don’t show this msg again for this room (you can see all devices by clicking on padlock, your sending won’t be blocked on new devices but you will be warned)

[send anyway] [verify the new devices (which opens the dashboard UI showing non verified devices only)]

Keyshare requests

Other notes:

uhoreg commented 7 years ago

I ran into an interesting situation today that I hope will be addressed by the new redesign somehow. I opened up a new device that hadn't been active for a while, while another device was active. Device A requested keys from device B, and device B requested keys from device A, which resulted in both devices asking me to verify the keys of the other device, but then with the "Verify device" dialog open on both devices, I can't open the user settings on either device to find out what my key actually is. (Of course, this could be solved by using a verification mechanism that doesn't require the users to actually view the keys.)

richvdh commented 7 years ago

no longer p1, unfortunately

ara4n commented 6 years ago

IT'S BACK AT P1 BABY!!!

t3chguy commented 1 year ago

The dialog this wishes to replace is long dead