search

element-hq / riot-android

A glossy Matrix collaboration client for Android
Apache License 2.0
1.4k stars 394 forks source link

Local contacts should utilize the IM field type too #2034

Open nesbocaj opened 6 years ago

nesbocaj commented 6 years ago

It seems to me like Riot primarily uses the Email field of contacts to look for Riot and matrix ids, however the Contacts app also exposes a perhaps more appropriate field type for this kind of information, IM.

Thus I suggest that Riot is made aware of these fields and uses them to find Riot and matrix ids.

Ekleog commented 6 years ago

I'd add to this that I expected the “Matrix contacts only” checkbox to do exactly this. It looks like I was wrong and from my reading of the source code (as I'm not familiar with it I may completely be wrong!) it looks like it instead sends all the emails and phone numbers in the address book to the identity server? Thankfully I had replaced the vector.im identity server by a non-existing one just in case, but discovering this after the fact was... unexpected.

(hopefully this adds insight on the naming of the options to do this, and does not bring the issue out of the original topic)

pklapperich commented 4 years ago

Basically the people tab is completely useless and a waste of UI unless your contacts use 3PIDs. For some contacts (ex those made online) I will only ever have a matrix id