elementary / notifications

Gtk Notifications Server
https://elementary.io
GNU General Public License v3.0
38 stars 6 forks source link

Notification settings don't work for Spotify #151

Closed ckruse closed 3 years ago

ckruse commented 3 years ago

Prerequisites

Describe the bug

Notification settings for Spotify (Flatpak version) seem to get ignored. I set the following notification options for Spotify:

Screenshot from 2021-09-05 07 20 16

But when a song changes the notification sound gets played and the notification center shows an entry:

Screenshot from 2021-09-05 07-20-48

To Reproduce

Steps to reproduce the behavior:

  1. Go to notification settings and change notifications for Spotify
  2. Enable notifications for song changes
  3. Play a song and hit „skip“
  4. Notification sound plays, notification center has an entry

Expected behavior

Neither the sound should play nor the notification center should show the Spotifiy notification

Platform Information

davidmhewitt commented 3 years ago

It's an issue with Spotify, it doesn't identify itself to the notification server when it sends a notification.

I believe this is due to the fact that Spotify is built on electron and this used to be a bug with electron based applications, which was fixed here: https://github.com/electron/electron/pull/12192/files

So Spotify is probably still based on an old version of electron that doesn't contain that fix.

There's more details about this in https://github.com/elementary/wingpanel-indicator-notifications/issues/193 , so I'll close this issue as a duplicate of that.

ckruse commented 3 years ago

Dunno if this changes something, but Spotify doesn‘t use Electron. They built their own GUI framework, before Electron. They use the „chromium embedded framework,“ see https://www.spotify.com/de/opensource/

davidmhewitt commented 3 years ago

Ah well, maybe so.

Doesn't change anything though. It's a fact that the Spotify client doesn't sent a desktop-entry hint which is what would be required for it to be identified: https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#hints

sysfu commented 3 years ago

Is there anyplace or person at Spotify we can complain to in order to expedite getting this fixed?