search

elementary / os-patches

Patched packages for elementary OS and the tools that keep them up-to-date
GNU General Public License v3.0
18 stars 11 forks source link

Fix distributor ID to not be title case unless upstream #213

Closed vjr closed 2 years ago

vjr commented 3 years ago

Fixes #205

vjr commented 3 years ago

Fixes #205

Tested with mutiple Windows/Linux installations on the same drive and also by running and comparing command output lsb_release with and without the -u option after editing /etc/upstream-release/lsb-release to temporarily set the ID to lowercase ubuntu

The main elementary grub boot entry is now elementary instead of Elementary

vjr commented 3 years ago

Silly me... fixing this PR asap...

danirabbit commented 2 years ago

Hm, thinking about this more, does this mean our GRUB configuration is using ID where it should be using PRETTY_NAME? Would it make more sense to resolve that in our GRUB so we don't have to carry another patch here?

vjr commented 2 years ago

Is this PR resulting in addition of another patch to upstream package?

I guess I could look into using PRETTY_NAME on the grub side of things, give me a few days.

vjr commented 2 years ago

@danrabbit there is already a patched lsb-focal-patched branch to which this PR adds a diff to the existing lsb_release.py modifications so no new patch file being added.

Do we really want to use PRETTY_NAME still? That would be a simple change to /etc/default/grub to use the -d option instead of -i passed to lsb_release to set the GRUB_DISTRIBUTOR var which I can create a PR if you want.

It's a matter of whether you want to show just elementary in the grub boot menu as in previous releases or elementary OS 6 Odin going forward, so which is it?

davidmhewitt commented 2 years ago

Going to close this in favour of #222 . I don't like the idea of changing what lsb_release returns.

There may be random scripts online that target elementary and use lsb_release (and the specific casing it returns) to detect elementary.