search

elementary / os

The OS build system
https://elementary.io
GNU General Public License v3.0
1.01k stars 130 forks source link

arm64: Build on Noble #729

Closed ryonakano closed 2 weeks ago

ryonakano commented 2 weeks ago

Fix #727 Closes #728

The fix for https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/2054925 does not seem to be released for Ubuntu 20.04 LTS. This issue didn't occur when I tested on OS 8 RC, so switch build environment to Ubuntu 24.04 LTS.

Changes Summary

ryonakano commented 2 weeks ago

I built Raspberry Pi image on OS 8 RC natively and confirmed the image is generated:

Compressing elementaryos-8.0-daily-rpi-20241103.img
81dcf9a0cde5d060259c4250dafe3cb7  elementaryos-8.0-daily-rpi-20241103.img.xz
941ecf6706756fabc27f2c1340c1307390d7ffc2090cdc1b21085c0ff7a5bcc8  elementaryos-8.0-daily-rpi-20241103.img.xz
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
python3 is already the newest version (3.12.3-0ubuntu2).
The following additional packages will be installed:
  python3-botocore python3-dateutil python3-jmespath python3-s3transfer
The following NEW packages will be installed:
  python3-boto3 python3-botocore python3-dateutil python3-jmespath python3-s3transfer
0 upgraded, 5 newly installed, 0 to remove and 0 not upgraded.
Need to get 6439 kB of archives.
After this operation, 95.9 MB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu noble/main amd64 python3-dateutil all 2.8.2-3ubuntu1 [79.4 kB]
Get:2 http://archive.ubuntu.com/ubuntu noble/main amd64 python3-jmespath all 1.0.1-1 [21.3 kB]
Get:3 http://archive.ubuntu.com/ubuntu noble/main amd64 python3-botocore all 1.34.46+repack-1ubuntu1 [6211 kB]
Get:4 http://archive.ubuntu.com/ubuntu noble/main amd64 python3-s3transfer all 0.10.1-1ubuntu2 [54.3 kB]
Get:5 http://archive.ubuntu.com/ubuntu noble/main amd64 python3-boto3 all 1.34.46+dfsg-1ubuntu1 [72.5 kB]
Fetched 6439 kB in 4s (1781 kB/s)
Selecting previously unselected package python3-dateutil.
(Reading database ... 196853 files and directories currently installed.)
Preparing to unpack .../python3-dateutil_2.8.2-3ubuntu1_all.deb ...
Unpacking python3-dateutil (2.8.2-3ubuntu1) ...
Selecting previously unselected package python3-jmespath.
Preparing to unpack .../python3-jmespath_1.0.1-1_all.deb ...
Unpacking python3-jmespath (1.0.1-1) ...
Selecting previously unselected package python3-botocore.
Preparing to unpack .../python3-botocore_1.34.46+repack-1ubuntu1_all.deb ...
Unpacking python3-botocore (1.34.46+repack-1ubuntu1) ...
Selecting previously unselected package python3-s3transfer.
Preparing to unpack .../python3-s3transfer_0.10.1-1ubuntu2_all.deb ...
Unpacking python3-s3transfer (0.10.1-1ubuntu2) ...
Selecting previously unselected package python3-boto3.
Preparing to unpack .../python3-boto3_1.34.46+dfsg-1ubuntu1_all.deb ...
Unpacking python3-boto3 (1.34.46+dfsg-1ubuntu1) ...
Setting up python3-jmespath (1.0.1-1) ...
Setting up python3-dateutil (2.8.2-3ubuntu1) ...
Setting up python3-botocore (1.34.46+repack-1ubuntu1) ...
Setting up python3-s3transfer (0.10.1-1ubuntu2) ...
Setting up python3-boto3 (1.34.46+dfsg-1ubuntu1) ...
Traceback (most recent call last):
  File "/home/user/work/os/upload.py", line 9, in <module>
    client = session.client('s3',
             ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/boto3/session.py", line 299, in client
    return self._session.create_client(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/botocore/session.py", line 997, in create_client
    client = client_creator.create_client(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/botocore/client.py", line 161, in create_client
    client_args = self._get_client_args(
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/botocore/client.py", line 508, in _get_client_args
    return args_creator.get_client_args(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/botocore/args.py", line 137, in get_client_args
    endpoint = endpoint_creator.create_endpoint(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/botocore/endpoint.py", line 402, in create_endpoint
    raise ValueError("Invalid endpoint: %s" % endpoint_url)
ValueError: Invalid endpoint: https://
user@VirtualBox-c0504e30:~/work/os$ file artifacts/elementary-rpi/elementaryos-8.0-daily-rpi-20241103.img.xz
artifacts/elementary-rpi/elementaryos-8.0-daily-rpi-20241103.img.xz: XZ compressed data, checksum CRC64
user@VirtualBox-c0504e30:~/work/os$
ryonakano commented 2 weeks ago

Thank you for your review. I'm waiting if the build succeeds on GitHub Actions too, using my forked repo:

https://github.com/ryonakano/os/actions/runs/11655346065/job/32449922363

I'll mark this PR as ready once the above build succeeds.

ryonakano commented 2 weeks ago

Confirmed the build on GitHub Actions generates image and stops with the error of upload.py, so merging this and pray for successful build on our master branch too :pray: