elementary / os

The OS build system
https://elementary.io
GNU General Public License v3.0
1.01k stars 130 forks source link

pinebookpro: Fix build failing #734

Open ryonakano opened 2 weeks ago

ryonakano commented 2 weeks ago

This PR fixes building the image for Pinebook Pro failing (see https://github.com/elementary/os/pull/731#issuecomment-2453619649).

Changes Summary

ryonakano commented 2 weeks ago

I built this branch natively on my OS 8 RC and confirmed this generates a Pinebook Pro image. However, I can't test if the generated image works as expected because I don't have a Pinebook Pro.

@davidmhewitt @stsdc Do you have a PineBook Pro? If so, would you build this branch and check if the generated image is bootable on it?

ryonakano commented 2 weeks ago

Hmm, looks like build native generates an image successfully but build on Docker fails with the following error:

du: cannot access '/working_dir/artifacts/pinebook-pro/elementary-arm64/proc/336229/task/336229/fd/3': No such file or directory
du: cannot access '/working_dir/artifacts/pinebook-pro/elementary-arm64/proc/336229/task/336229/fdinfo/3': No such file or directory
du: cannot access '/working_dir/artifacts/pinebook-pro/elementary-arm64/proc/336229/fd/4': No such file or directory
du: cannot access '/working_dir/artifacts/pinebook-pro/elementary-arm64/proc/336229/fdinfo/4': No such file or directory
Creating image file
Warning: The resulting partition is not properly aligned for best performance: 62500s % 2048s != 0s
losetup: /working_dir/artifacts/pinebook-pro/elementaryos-6.1-daily-pinebookpro-20241104.img: failed to set up loop device: No such file or directory
[ryo@b760m ~/work/elementary/os (ryonakano/pinebookpro-fix-build)]$
ryonakano commented 2 weeks ago

OK, retrying the docker build generates the image succesfuly.