search

elementary / videos

Video player and library app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
59 stars 18 forks source link

Remove automatic fullscreen #361

Closed danirabbit closed 10 months ago

danirabbit commented 10 months ago

Closes #14

Remove all the automatic fullscreen stuff and put the regular headerbar in the revealer on the playerpage. Fixes issues with not always having access to navigation or window controls. It's still possible to fullscreen manually with a keyboard shortcut

TomiOhl commented 10 months ago

Note: afaict #51 is calling for an app-level volume setting - not having access to the system volume settings is a different thing. Imo this should only close #14

leolost2605 commented 10 months ago

Just looked at the edit history maybe you meant to remove #51 instead of #276 because the latter is fixed by this? I'll wait for you to merge :)

danirabbit commented 10 months ago

I thought so at first too but I think #276 wants any letter boxing or pillar boxing to also disappear with the window controls