Closed leolost2605 closed 1 year ago
It's all in all pretty connected but some minor changes that are required for this could be split out if necessary
So excited for this. Way cleaner. Can you resolve conflicts with main please? :)
Also fixes an issue where you could play/pause, go next and previous while the player was not open. If we want we could automatically show the player instead of disabling right away?
Yeah having the play action switch to the playerpage would be pretty dope, but could wait for another branch imo
Repeat now takes precedence of the next item in the play queue which is I think how it should be?
We could probably follow up in another branch to make sure we have "repeat all" and "repeat one" like Music has it
I noticed that when I add files from the playlist popover they are prepended to the list instead of added to the end of it 😅
Fixed :)
Move the playqueue to the playback manager, make it a StringList and bind this list to the playlistpopover listbox
This gets rid of the convoluted signal chains
Remove the play () signal and instead always either play from Window or directly from the PlaybackManager. This reduces some duplicated effort when playing videos from the PlaylistPopover because previously we would create a file send the play signal in the PlaybackManager with this file causing the window to open the file try to add it to the playlist agiaing and then eventually do play_file in the PlaybackManager. Instead we now do play_file right away because we can assume that the Player is already visible when choosing a video from the playlist and we know all videos in the playlist are actually videos.
We allow appending multiple files at once to the play queue which allows us to have IMO better toasts, so when only the video that is actually playing gets added to the playlist no toast is sent, when one additional video gets added a toast with its title is sent and when more than 2 get added a toast with n videos added to playlist gets sent.
Also fixes an issue where you could play/pause, go next and previous while the player was not open. If we want we could automatically show the player instead of disabling right away?
Repeat now takes precedence of the next item in the play queue which is I think how it should be?