search

elfbutt / koreader-coverbrowserclean

Edits to the KOReader Cover Browser plugin
http://koreader.rocks/
GNU Affero General Public License v3.0
1 stars 0 forks source link

Remove/Enforce Settings #23

Closed joshuacant closed 2 months ago

joshuacant commented 2 months ago

We're making a lot of choices about coverbrowser settings that we might not even be aware of.

We should do a fresh koreader install and a fresh coverbrowser install to see what it looks like with defaults.

We should then remove/constrain/force settings as needed. Priority should be (imo) on preventing the UI from breaking but allow as much choice as possible.

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> progress -> currently % is always shown, the "show num pages instead of %" toggle should be either renamed to "show num pages" OR the setting should actually switch between the two

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> progress ->"show num pages left to read" works, but kinda ugly, also uses the "to read" phrase so maybe "New" for unopened books should say "To Read" to match

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> display hints-> all of these are silly. description does put a little rectangle in there, but the other 2 don't seem to do anything. i vote: get rid of this entire settings block and force them off.

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> series ->

append to authors: works, looks fine. append to title: works, looks stupid. separate line: the GOAT option. works and looks good. no series options selected: works.

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> show file properties: yeah so this is just skipped entirely if the P(XXX) code activates. should probably fix that.

elfbutt commented 2 months ago

filing cabinet -> settings -> mosaic settings -> progress -> currently % is always shown, the "show num pages instead of %" toggle should be either renamed to "show num pages" OR the setting should actually switch between the two

if we accidentally disabled some settings we probably just need to look for the original flag that controlled them and add it back in to cover our new stuff

joshuacant commented 2 months ago

filing cabinet -> settings -> mosaic settings -> display hints-> all of these are silly. description does put a little rectangle in there, but the other 2 don't seem to do anything. i vote: get rid of this entire settings block and force them off.

Description hint settings menu item is commented out, along with the description hint code in listmenu. covermenu doesn't seem to have any code that references the description hint. description hint code commented out in mosaicmenu.

joshuacant commented 2 months ago

All of the settings under the "Progress" sub-menu work as expected.

Still need to do the fresh install test, and maybe other things, so I'm keeping this open to track those things and more!

joshuacant commented 2 months ago

New options and default for portrait list items per page set.

%1 bug remains in classic mode item font size.

joshuacant commented 2 months ago

I think with the splitting off of that one, we're done here. Wrap it up.